Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that module scope variables of extern types are default initalized #26417

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make sure that module scope variables of extern types are default initalized #26417

wants to merge 3 commits into from
+7 −0

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Dec 16, 2024 •
edited
Loading

Fixes an issue where module scope variables of an extern type where not default initialized properly. This was caused by a dead store of PRIM_ZERO_VARIABLE to a temporary, created by makeHeapAllocations in the parallel pass.

The fix is to just set the temporary back to the "pointer"

This PR also adds a NUMLOCALES file to some C extern tests to ensure they are run in nightly gasnet+asan tests

Resolves #26406

Testing

  • ran start_test with GASNet + ASAN tesing on test/extern/bharshbarg/ and test/extern/ferguson/
  • full paratest without comm
  • full paratest with comm

[Reviewed by @mppf]

@jabraham17 jabraham17 requested a review from mppf December 16, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mppf mppf mppf approved these changes

Assignees
No one assigned
Labels
stat: Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Chapel variables with extern types may not be default initialized
2 participants
@jabraham17 @mppf